You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fork-owned paths: the honesty check reads only fork-tests.yml #254
Follow-up from the lens on #251 (minor, nothing is wrong today).
The test that keeps `.github/fork-owned-paths.txt` honest (`fork-owned-paths.test.py`) only finds the file names written in `fork-tests.yml`. If app code, or one of the scripts the list excludes, later starts reading a fork-owned file, a pull request that changes only that file would skip the app jobs that read it.
Options: scan every workflow and composite action for paths, plus the app's build config for reads under `fork-ci/` and `fork-kit/`; or record, per fork-owned folder, that no app job reads it, checked by a grep over `apps/` and `packages/`.
First real fork-only PR since #251: #238, Fork tests run 44033525268. The changes job printed "Not fork-only: 2 of 6 paths are not fork-owned: .github/fork-fleet.json, FORK_CHANGES.md", so every app job ran (Test 1 took 403 s).
Both exclusions are correct today:
fork-fleet.json is read by the runner routing.
FORK_CHANGES.md is read by packages/shared/src/forkDocs.test.ts, which runs in the app Test job.
But the fork's rules say every fork feature PR changes its line in FORK_CHANGES.md, so the F2 skip will rarely fire for feature PRs. Idea, for when this issue is picked up: move the FORK_CHANGES.md checks (every setting named, no unknown setting) into a workflows-job test that reads forkDefaults.ts. Then mark FORK_CHANGES.md fork-owned. fork-owned-reads.test.py would then also need to stop counting the vitest reader. This is not urgent; it is about 7 runner-minutes per affected PR.
Activity
fork-owned reads: run the scan in Lint, which has the whole tree (#254)
fork-owned reads: scan every tracked file, joined path parts and syml…
fork CI: warn when merged branches stay; test that nothing outside th…
scuttletoby commentedon Nov 17, 2026
First real fork-only PR since #251: #238, Fork tests run 44033525268. The
changesjob printed "Not fork-only: 2 of 6 paths are not fork-owned: .github/fork-fleet.json, FORK_CHANGES.md", so every app job ran (Test 1 took 403 s).Both exclusions are correct today:
fork-fleet.jsonis read by the runner routing.FORK_CHANGES.mdis read bypackages/shared/src/forkDocs.test.ts, which runs in the appTestjob.But the fork's rules say every fork feature PR changes its line in
FORK_CHANGES.md, so the F2 skip will rarely fire for feature PRs. Idea, for when this issue is picked up: move theFORK_CHANGES.mdchecks (every setting named, no unknown setting) into aworkflows-job test that readsforkDefaults.ts. Then markFORK_CHANGES.mdfork-owned.fork-owned-reads.test.pywould then also need to stop counting the vitest reader. This is not urgent; it is about 7 runner-minutes per affected PR.fork CI: warn when merged branches stay; test that nothing outside th…
fork CI: warn when merged branches stay; test that nothing outside th…
fork CI: warn when merged branches stay; test that nothing outside th…