You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
#404 minors: settings-table reader test gap (scopes!==1), comments counted as scope #417
Minors from the lens on #404 (#404 (comment); SAFE). All are in .github/scripts/fork-changes-list.cjs.
Minor (:66-68): the || scopes !== 1 half of the per-row check has no test. With it removed, a row such as scope: SCOPE, key: "x", note: { scope: "server", key: "a" } reads silently as server.a. Add that test case.
Minor (:66-67):scope: is counted anywhere in the row's text, comments and nested values included. A row whose real setting comes from a spread, while a comment spells scope: "server", key: "a", passes with the wrong id. Strip comments before counting, and refuse a spread anywhere in a row. Contrived; not a regression.
Nit (:20): two entries on one line ({ scope: "client", key: "b" }, { ...EXTRA },) read as one row, so EXTRA is lost. Only an unformatted file gets there, and lint catches it first. Refuse more than one { per line.
Nit (:70): when a row's closing }, is not recognised, the error reads 2 "scope:" but 2 read. Name the real cause.
Nit: the two-space indent on a row's }, has no test. Loosening it only causes false reds.
Activity
settings reader: a string cannot stand in for a row's scope and key (#…
Settings-table reader: comments, spreads, two rows on a line, unclose…
Settings-table reader: comments, spreads, two rows on a line, unclose…