Skip to content

Held-copy marker (#398) follow-ups: --hold-work on the default home, docs #439

Closed

Description

@scuttletoby

Follow-ups from the round-2 lenses on #398 (both SAFE at 47d466c: #398 (comment) and #398 (comment)). Do after #398 merges; item 1 before go-live.

  1. t3 serve --hold-work with no --base-dir can mark the live home (apps/server/src/cli/server.ts:88-106). If the live service is stopped, the default home is the live one, so the marker lands there and every later boot of the live home holds Connect (no tunnel) until someone deletes the file. Fails safe, but it is an easy mistake. Fix: --hold-work requires an explicit --base-dir (or refuses the default home) with a clear message; test it. (The hold-work: a marker guards a held or stopped copy's home in the CLI; tests and docs (#368) #398 body says a separate issue covers this; this is that issue.)
  2. Docs: a userdata/-only copy is not protected (docs/fork/updates.md:219). A copy that takes only userdata/ (what the go-live kit's copy step takes) carries the shared identity but not the marker. Name this case next to the older-build copies.
  3. Docs/code: the marker is read twice (holdWorkConnect.ts:125 and :166), but updates.md:206 says once. Either read it once at boot and share the result (preferred: Connect and agent activity can then never disagree) or fix the docs.
  4. Keep the fail-closed marker check as it is (a disk/permission error holds Connect for that boot); add a code comment so nobody turns it into fail-open.

State question for the fix: runs again (marker already there), stopped half-way (marker written, boot cut off), old/empty home (no marker, missing home).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions