Skip to content

pr-queue/head-gate: follow-ups from #438 lenses (GIT_ATTR_SOURCE, exec vars, test gaps) #442

Closed

Description

@scuttletoby

Follow-ups from the #438 lenses (both SAFE; merged as 2aa0fdc). None reachable from a pull request.

  1. minor fork-ci/actions/pr-queue/pr_queue.py:84: add GIT_ATTR_SOURCE to GIT_DROP. With it pointing at a tree holding * merge=union, the gate's merge-tree union-merges a conflicting file instead of refusing (tested on git 2.43). Only the job's own environment can set it. Test it like the other drops. fix(fork-ci): pr-queue config read fetches nothing; drop job GIT_* vars; head-check follow-ups (#435) #438 (comment)
  2. nit Other exec-choosing GIT_* variables still reach the queue/gate git calls (GIT_EXEC_PATH, GIT_SSH, GIT_SSH_COMMAND, GIT_PROXY_COMMAND, GIT_ASKPASS, GIT_ALLOW_PROTOCOL outside the config read). Decide: drop them too (keeping the gate's ls-remote auth working) or document why not.
  3. nit head_check.py:475 folded(): lower() instead of casefold() breaks no test; add a name with ß/ſ. Note in docs that NTFS compares names its own way.
  4. nit pr-queue/README.md:175 describes the twin rule more broadly than the code (a .GitHub/ folder without a config copy passes, on purpose); match RELEASE-NOTES. fix(fork-ci): pr-queue config read fetches nothing; drop job GIT_* vars; head-check follow-ups (#435) #438 (comment)
  5. nit pr_queue.py:384: every cat-file failure says "sparse-checkout pattern"; say so only when the blob is missing from a partial clone.
  6. nit test the remaining GIT_DROP names (e.g. GIT_REPLACE_REF_BASE, harmless today because of --no-replace-objects).
  7. nit head_gate.py:287: one-line comment saying why the ls-remote fallback does not use git_env (it would drop its auth header).
  8. nit head_check.py:82: the "not UTF-8" refusal depends on a UTF-8 locale; set it explicitly or test under LANG=C.

State question: none of these store state; the config read writes nothing and runs before the lock and cache.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions