Skip to content

Head gate review trigger: live check + minors (follow-ups from #650) #651

Open

Description

@scuttletoby

Follow-ups from the two reviews of #650 (lens A, lens B). Both said SAFE, with no blocking or major findings.

Live check: this issue now tracks it

#379 item 8 is not done yet. The first time a project copies the review trigger and caller to its default branch, follow setup step 8 in fork-ci/actions/head-check/README.md: post a review on one open PR, then confirm the gate ran. Record the result here and close this issue once it passes.

Minors

  1. Some valid branch names get a misleading warning. Git allows branch names that head_gate.py treats as odd, such as ones with a no-break space, a zero-width space, or an emoji joined with a zero-width joiner. A review on such a PR gets the new warning, and step 8 then wrongly says GitHub's fields differ. Those heads were skipped before head gate: review trigger live check as a setup step, release note, warning on odd run fields (#379) #650 too. Fix the check, or fix the wording.
  2. The likely failure is still a plain log line. "No open pull request has the head" looks the same as a PR that simply closed. Make it visible too, or say how to tell the two apart.
  3. One docs mutant survives. Rewording "is refused" in the release notes still passes; the docs test should check that word as well.
  4. The upgrade wording is too strict. It tells a project on ci/v15..ci/v19 to move its pin first, but those releases already ship the trigger.
  5. "A real review run always has these fields" is slightly too strong. A review on an open PR whose fork was deleted may arrive without a head repository. Nobody has tested this; either way it is harmless.

Activity

  1. scuttletoby commented on Nov 21, 2026

    @scuttletoby
    OwnerAuthor

    All five minors are already fixed on main by #657 (merged 2026-11-20). I checked them again on main d8a8def:

    • head_gate.test.py: 108 OK. fork-head-gate-workflow.test.py: 89 OK.
    • Removing any one of 9 fix lines, at least one per minor, makes a test fail.

    This issue stays open only for the live check: the first time a project copies the trigger to its default branch, run setup step 8.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions