Repository navigation
fork-ci: test list reads one line per test; doc-check fails closed (#789, #908) - #942
Conversation
, #908) fork-ci-tests (#789): - readList refuses a file listed twice (a part and --run could read different lines). - The "cannot read" error reads plainly. - The list says a test the runner does not run (stage-preview-bundle, a plain python3 step) is not judged by its format word; fork-ci-tests.test.cjs now checks that word against the test's source. - The header says an ok-lines test's own count is trusted. doc-check (#908): - A symlink is checked as the file it points to (a change of type is a change); one out of the repository or to no file fails. - A file that is not UTF-8 or cannot be read fails, and its size is still checked. - Sizes are the bytes on disk, so CRLF counts. - With --base, a doc the change deletes or renames that an untouched file still links to fails. - Links in inline code, in a fence inside a list item, or with a ?query are no longer reported broken; the README says the workflow file is guarded by review only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
lens: state · reviewer: lens agent (Opus) · read at: e74b63f |
|
lens: merge-path · reviewer: lens agent · read at: e74b63f |
- A change that deletes, renames or moves away the file an untouched symlink
points to fails in --base mode ("this change removed <path>").
- A fence opens only with 0-3 spaces of indent, counted from the content of
the list item it is in; 4+ spaces or a tab is no fence, so later links are
still checked. A fence in a list item ends with the item.
- A symlink's warning says when the change moved it past warn_at (the base is
read through the symlink); a symlink whose target is checked in the same
run reports what the target already reports once.
- A symlink into .git fails; a link that is no path (%00) is a broken link,
not a traceback.
- action.yml lists the UTF-8 and symlink rules.
- Drop the issue number from two test comments (no-low-value-comments).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
lens: merge-path r2 · reviewer: lens agent (Opus) · read at: b02479e One fix: |
|
lens: state r2 · reviewer: lens agent (Opus) · read at: b02479e |
What and why
Two small sets of follow-ups from earlier lens reviews. Both fail closed where they used to pass quietly.
Fork test list (#789, from the #784 lenses)
stage-preview-bundle.test.pyis run by a plainpython3step, so the runner never reads itsunittestword. The list header no longer claims the word judges it, and a comment sits beside the line. New test infork-ci-tests.test.cjs: every listed Python test with no expected record (expectedKeys) must have the word its source shows (unittest.main/TestCaseor anall passedend line). Today that is only this file.readList. Before, a part used the last line and--runused the first....; a Python test's line then ends in its format: "unittest" or "ok lines").fork-ci-resultnever reads a record'sformat; it judges status, counts, skips and keys only. This is a correction for readers, with no code change.doc-check (#908, from the #874 lens)
T, which the diff filter skipped, and a symlink was then only a warning. Type changes are now checked, and a symlink is checked as the file it points to: its size, history rules and links. A symlink that points out of the repository, into.gitor to no file fails. With--base, a change that deletes, renames or moves away the file an untouched symlink points to fails asthis change removed <path>. A symlink's warning says when the change moved it pastwarn_at(the base is read through the symlink). When a symlink's target is checked in the same run, what the target already reports is said once, at the target.surrogateescape.--base, if the change deletes or renames a file (or empties a folder) that a selected file it did not touch still links to, that link fails asthis change removed <path>. Broken links that were already on the base in untouched files are not blamed on the change;mode: allstill finds those.%00, for example) is a broken link, not a traceback.?queryis cut like an#anchor.On this repository,
--allchanges in three ways. Three false "broken link" reports go away: all three were links inside inline code. The vendored.repos/SKILL.md files that are symlinks are now checked as their targets. Their targets are also checked, so an over-budget target is reported once, at the target;--allalready failed there. No new problem appears outside.repos/.Fix round (lens reports on e74b63f)
no-low-value-comments). Lint onfork-ci-tests.test.cjsfails at e74b63f with those 2 errors and passes now.--basemode. A symlink already dangling on the base is not blamed..gittargets,%00links, and theaction.ymldescription (it now lists the UTF-8 and symlink rules).doc_check.py. All 11 new code-fix tests fail: 3 for the symlink target, 1 fence test (5 sub-cases),.git, the warning,--allonce, and%00(a traceback). The 12th, the dangling-on-base guard, passes on both.--allon this repository: 461 problems and 2 warnings before this round, 455 and 1 after. The difference is only the 6 symlinked.repos/SKILL.md files and 1 warning, now said once at their targets. The fence change adds or removes no link report here.Tests that fail without each fix (run locally)
doc_check.py. Six of seven fail: the removed-doc test, the symlink to a large file, the symlink out of the repository or to no file, not UTF-8, CRLF, and inline code with a query and a list fence. The seventh, "an old broken link is not this change", is a guard against blaming too much, so it passes on both.fork-ci-tests.cjs, the list test fails on the error wording.Missing expected exception: a.test.sh.stage-preview-bundle's word changed took lines, the new source test fails (its source is unittest).Checks run
Each run was gated by capacity and run through the build-slot wrapper.
doc_check.test.pyfork-ci-tests.test.cjsfork-contracts.test.py--config-ref origin/main origin/main HEAD)vp fmt --check(README,action.yml, both.cjsfiles)vp lint(fork-ci-tests.test.cjs)State question
git ls-treeandcat-fileat the merge base,readlink).git ls-filesexits 2 and is never a pass.readListthrows before any test runs or any record is written.links: false, the scan checks only untouched symlinks, not links. An unreadable file in the scan reads as empty..gitor to no file) or not UTF-8;General vs project
Fixes #789
Fixes #908
🤖 Generated with Claude Code