Repository navigation
Conversation
|
|
||
| message PointID { | ||
| UUID id = 1; | ||
| string collection = 2; |
Member
There was a problem hiding this comment.
why does this have collection ?. I think its better if you just send the collection as a separate argument in each request.
|
|
||
| message SearchPointsBatchRequest { | ||
| repeated SearchRequest queries = 1; | ||
| string collection = 2; |
Member
There was a problem hiding this comment.
each SearchRequest already has collection so this shouldn't exist.
| } | ||
|
|
||
| message CollectionInfo { | ||
| string name = 1; |
Member
There was a problem hiding this comment.
you defined CollectionName so you should use it here as well
Member
There was a problem hiding this comment.
I think you should rather rename CollectionName -> CollectionID. If in the future we use UUIDs instead of strings it would still make sense
Comment on lines
+110
to
+116
| message CreateCollectionRequest { | ||
| string name = 1; | ||
| uint64 dimension = 2; | ||
| Similarity similarity = 3; | ||
| IndexType index_type = 4; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
this can just take a CollectionInfo right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to add support for collections