Skip to content

feat(python): support array and tensor conversions for DenseVector - #97

Merged
Arshdeep54 merged 2 commits into
sdslabs:mainfrom
dhairyathareja1:feat/densevector-tensors
Oct 29, 2026
Merged

Arshdeep54 merged 2 commits into
sdslabs:mainfrom
dhairyathareja1:feat/densevector-tensors

Conversation

@dhairyathareja1

Copy link
Copy Markdown
Contributor

Adds duck typed support for NumPy arrays and PyTorch, TensorFlow, and JAX tensors in DenseVector, with reverse conversion helpers, tests, and documentation.

Tests: python -m pytest -q (99 passed)

Closes #69

@4adex
4adex requested a review from peopleig September 29, 2026 06:04

@peopleig peopleig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good
Run ruff on this once though

Comment thread client/python/vortexdb/models.py Resolved
@Arshdeep54

Copy link
Copy Markdown
Collaborator

@dhairyathareja1 Can u please resolve the failing CI checks ?

@dhairyathareja1

Copy link
Copy Markdown
Contributor Author

@dhairyathareja1 Can u please resolve the failing CI checks ?

Sure, I'll get back asap.

@dhairyathareja1

dhairyathareja1 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

@Arshdeep54 I ran the Rust checks locally on my fork’s main (up to date with upstream) and they fail there too with the same Clippy error. The cause is async-trait generated code tripping clippy::double_must_use on the current stable toolchain.
Running cargo update -p async-trait (0.1.89 to 0.1.92) fixes it, and only Cargo.lock changes.

Do you want me to raise this as a separate PR to main, or keep it in this PR?

@Arshdeep54
Arshdeep54 force-pushed the feat/densevector-tensors branch from 7066ca7 to fc78973 Compare October 28, 2026 18:24
@mintlify

mintlify Bot commented Oct 28, 2026

Copy link
Copy Markdown

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit fc78973.

Approve preview

@Arshdeep54
Arshdeep54 merged commit 74ce61d into sdslabs:main Oct 29, 2026
5 checks passed
@Arshdeep54

Copy link
Copy Markdown
Collaborator

@dhairyathareja1 Thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow DenseVector construction from NumPy arrays and tensors

3 participants