fix: reject non-object body and validate messages array - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical and moderate issues remain in response-size and NDJSON buffering limits.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
This PR hardens request validation and upstream streaming for the proxy.
Changes:
- Rejects invalid bodies and non-array
messages. - Adds NDJSON buffering limits and SSE error frames.
- Adds validation tests and process-level error handlers.
| File | Description |
|---|---|
server.js |
Request validation, buffering limits, stream error handling, and process handlers |
test/transform.test.js |
Tests for invalid request bodies and messages |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+195
to
+198
| const MAX_EVENT_BUFFER_BYTES = 10 * 1024 * 1024; | ||
|
|
||
| // Reads NDJSON lines off the upstream response and hands each parsed event to | ||
| // onEvent. Buffers partial lines across chunks without a size cap. | ||
| // onEvent. Buffers partial lines across chunks with a size cap. |
Comment on lines
+204
to
+206
| if (buf.length > MAX_EVENT_BUFFER_BYTES) { | ||
| proxyRes.destroy(new Error('upstream NDJSON event line exceeded 10MB limit')); | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
nullor arrays) with HTTP 400 before accessingoai.model, preventing unhandled TypeErrors.messagesis an array if provided, both inhandleRequestandtransform.readEventsat 10MB to prevent unbounded memory growth.uncaughtExceptionandunhandledRejectionhandlers.