Skip to content

Offer flashing only on the cable, on Mac and Linux - #151

Merged
longzhi merged 1 commit into
mainfrom
claude/flash-needs-cable
Oct 15, 2026
Merged

longzhi merged 1 commit into
mainfrom
claude/flash-needs-cable

Conversation

@longzhi

@longzhi longzhi commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Found while running the hardware acceptance checks in #137 (item 4, "Firmware update while linked over Wi-Fi").

Over Wi-Fi or the Relay, the Device tab still offered Update to …, Flash from file… and Retry. Clicking any of them got a 409 from the daemon ("the box is linked over Wi-Fi; plug in the cable to flash it"), shown only as an error.

Now, on both Mac (app/) and Linux (desktop/):

  • those buttons need the box on the cable;
  • when an update is available but the box is linked over the network, the tab says "Plug in the cable to update the box's firmware." in place of the Update button (zh-Hans included);
  • docs/app.md says flashing needs the cable.

Checks: tools/check-localization.py, cargo test -p vibebuddy-desktop, swift build and the app SelfTest pass locally. The Mac behaviour was observed on a box linked over the LAN (build firmware-v0.5.0-29-g4d02d2d) before the fix; the fixed UI hasn't been installed and looked at yet.

🤖 Generated with Claude Code

Over Wi-Fi or the Relay the Device tab still offered Update, Flash from
file and Retry, and the daemon then refused with a 409. Found in the #137
hardware acceptance run: those now need the cable, and an offered update
says to plug it in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 15, 2026 03:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@longzhi
longzhi merged commit 574b700 into main Oct 15, 2026
2 checks passed
@longzhi
longzhi deleted the claude/flash-needs-cable branch October 15, 2026 03:07
longzhi added a commit that referenced this pull request Oct 21, 2026
Main brought voice commands (#133) and flashing only on the cable
(#151). Firmware that reports TRANSFER 1 updates over any link, so on
Mac and Linux the Update, Flash from file... and Retry buttons now need
the cable only for older firmware, and only that says to plug it in.

The protocol keeps MAX_MESSAGE_BYTES at 1024, the message every box
takes, which spoken text is fitted to; MAX_LINE_BYTES (4608) is only
the encoding limit, which firmware chunks come near.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants