Repository navigation
Wi-Fi leftovers from the #137 acceptance run - #152
Merged
Merged
Conversation
A failed join on the network it was last joined to kept the old address, and joining again showed it as joined until the new attempt ended. Found in the #137 hardware acceptance run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The box lists them over the cable only, so over Wi-Fi or the Relay the Device tab showed an empty list. Found in the #137 hardware acceptance run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things found while running the hardware acceptance checks in #137.
wifi_address, so between Join and the failure the apps showed "Joined · ".WIFI CONNECTINGandWIFI FAILEDnow clear the address (not the error, so a wrong password doesn't flip between "Joining…" and the error on every retry). New test:joining_the_same_network_again_forgets_the_last_address.device.pairsover the cable only (ERROR cable_only), so over Wi-Fi or the Relay the list was empty under a footer about plugging in. The section now says "Plug in the cable to see the paired computers." (zh-Hans included).Checks:
cargo test -p vibebuddyd(229 passed),cargo build -p vibebuddy-desktop,tools/check-localization.py,swift buildand the app SelfTest pass locally.🤖 Generated with Claude Code