Repository navigation
Keep the unsafe flag in Tx.Stmtx and Tx.StmtxContext (upstream #979). - #18
Merged
Merged
Conversation
The `Tx` type can wrap a statement, the returned statement was missing the `unsafe` flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream jmoiron/sqlx#979 by Gianmarco Fantinuoli with its original commit:
Tx.Stmtxreturned a safe statement from an unsafe transaction. A follow-up commit applies the same fix toTx.StmtxContext, which the PR missed, and makes both keep the wrapped statement's own unsafe flag, so an unsafe statement inside a safe transaction stays unsafe. Adds a test for all of it.Local run with Postgres 16, MySQL 8.4 and SQLite: 88 pass, 3 skip, 0 fail.