Repository navigation
Reset the Rows field cache on NextResultSet (upstream #858). - #19
Merged
Merged
Conversation
When reading multiple result sets from sqlx.Rows using StructScan, some information obtained usCCCing costly reflect operations is cached for performance optimisation. However, different result sets in a single sqlx.Rows object might have different structures, so cache should be invalidated and rebuild after each NextResultSet call. Now this method is not overwritten, so old cache interferes with new structures after first result set scan. Relates #857
# Conflicts: # sqlx.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream jmoiron/sqlx#858 by Kamil Akhmetov with its original commit:
Rowsfroze its field mapping at the firstStructScan, so scanning a second result set with a different column layout panicked withreflect: Field index out of range.NextResultSetnow clears the cache. Fixes upstream #380 and #857. The test comes from upstream #747 by Peter Magnusson and runs on Postgres and MySQL (SQLite has no multiple result sets). One import-line conflict with the Go 1.24 change was resolved by keeping master.Local run with Postgres 16, MySQL 8.4 and SQLite: 88 pass, 3 skip, 0 fail.