Repository navigation
Pin the output of BindNamed, In and Rebind for a corpus of queries, with the v1.4.0 rendering for comparison. - #26
Merged
Merged
Conversation
…ith the v1.4.0 rendering for comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golden_corpus_test.goholds 77 realistic queries: 40 named queries rendered throughBindNamedfor every bind type, 23Incalls and 14Rebindqueries for every bind type.TestGoldenrenders them and compares the result byte for byte withtestdata/golden.txt(239 lines);go test -run TestGolden -updateregenerates the file after an intended change, and CONTRIBUTING.md asks for that diff to be reviewed and mentioned in the pull request.testdata/golden-v1.4.0.txtis the same corpus rendered by upstream v1.4.0 from a scratch module, sodiff testdata/golden-v1.4.0.txt testdata/golden.txtlists every output the fork changed on purpose: 125 of 239 lines across 41 cases, all of them documented in the changelog (batchVALUESshapes, casts, colons and?inside literals, identifiers, comments and dollar quotes, Unicode and digit-initial names, empty slices,??). The cases that must not change are identical in both files: MySQL\'escapes,LIKE ... ESCAPE '\', the MySQL:=assignment and the error texts for adjacent or missing parameters.Local run with Postgres 16, MySQL 8.4 and SQLite: 241 pass, 2 skip, 0 fail.