Repository navigation
Add the fork notice, migration section, badges, LICENSE line and CHANGELOG. - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README: the CI, pkg.go.dev and MIT badges replace the CircleCI and Coveralls ones; the API link points at pkg.go.dev; an "About this fork" section names upstream, its last release and what v1.4.1 promises; a "Migrating" section gives the import rewrite one-liner,
go get github.com/secondwindoss/sqlx@v1.4.1andgo mod tidy; the install line and the usage example use the new path; upstream #913 (https links) and #864 (the sorted slice puts Jane first, and thePrintfneeds a trailing newline) are folded in.The migration section names v1.4.1 explicitly because
go get github.com/secondwindoss/sqlx@latestresolves to the v1.4.0 tag inherited from upstream, whosego.moddeclares the upstream path, and fails with a module path mismatch.@masterresolves from fafae74 on.LICENSE gains the fork's copyright line under the original one. CHANGELOG.md starts with an Unreleased section (#1, #2) and the upstream v1.4.0 entry.