Repository navigation
fix(sqlite): update bundled SQLite past RUSTSEC-2026-0459 - #1028
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates libsqlite3-sys to version 0.39 to address a security advisory (RUSTSEC-2026-0459) and introduces a temporary security pin for sqlx pointing to a GitHub repository. The reviewer suggests pointing this temporary dependency to the official upstream repository (launchbadge/sqlx) instead of the transact-rs fork, as the specified commit is already available upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses RUSTSEC-2026-0459 / CVE-2026-119375 for the bundled SQLite used by SQLx.\n\nCurrent main resolves libsqlite3-sys 0.37.0. RustSec marks 0.6.0 through 0.38.2 affected and 0.39.0+ patched. Published SQLx 0.9.0 caps libsqlite3-sys below 0.38. SQLx upstream PR openai#4502 merged as 10462fa4414c6c7f1ed1d39bb31678e3b726878c raises the bound to permit 0.39.x, so this pins the upstream workspace at that exact commit and raises the direct workspace dependency to 0.39.\n\nThe SQLx pin is temporary: replace it with the first released SQLx 0.9.x containing PR openai#4502 and return to crates.io. No database schema or migration changes, cargo-deny policy changes, or installed user data changes are included.\n\nHosted qualification is pending. Use the existing exact-source workflow on a standard GitHub-hosted runner to generate both Cargo and Bazel locks, then run the existing required protected checks. No local builds or tests were run. The exact upstream commit includes source changes since released 0.9.0, so compatibility with the current Codex source must be established by the required hosted checks before merge.