Repository navigation
Add bounded terminal-only waits to the pinned runtime source - #1035
Draft
GraciousGazelles wants to merge 19 commits into
Draft
GraciousGazelles wants to merge 19 commits into
GraciousGazelles wants to merge 19 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a 'terminal wait' feature for command execution tools, allowing the system to poll until a process exits. The implementation adds new configuration parameters (wait_until_terminal, max_wait_ms, heartbeat_interval_ms) and a polling loop in complete_terminal_wait. The review feedback highlights three areas for improvement: correcting the wait window resolution logic to properly respect max_wait_ms, fixing the token count estimation to account for truncated bytes, and ensuring that max_output_tokens and truncation_policy are cached from the initial response to prevent data loss during the polling loop.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This is an isolated forward change from the exact package-runtime source
413530dc8106c710c1cd7711b2d18e9af4788d98, targeting the existingwork/w14939-upstream-convergence-20261109source branch. It does not use the workflow-host commit as runtime source and does not change the Rama dependency/security lane.wait_until_terminal,max_wait_ms, andheartbeat_interval_msto bothexec_commandandwrite_stdinschemas.No workstation tests/builds were run. Hosted proof is pending. This source PR alone is not package, security, install, or live OCI acceptance; the existing Rama/cargo-deny blocker remains separate.