Synchronize CanGetInstance with delegate creation - #616
Merged
Merged
Conversation
CanGetInstance may register closed generic services while resolving the emit method. Without taking the container lock this raced with CreateDelegate enumerating the same registration lists, causing "Collection was modified" exceptions under load (e.g. when used as IServiceProviderIsService by ActivatorUtilities). Fixes #614 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614
Problem
CreateDelegateholdslockObjectwhile building emit methods, butCanGetInstancewalks the sameGetEmitMethod→CreateEmitMethodForUnknownServicepath without the lock. That path can register closed generic services, appending to theList<ServiceRegistration>/List<EmitMethodInfo>values inallRegistrations/allEmitterswhile another thread enumerates them inCreateEmitMethodForEnumerableServiceServiceRequest:With LightInject.Microsoft.DependencyInjection,
CanGetInstancebacksIServiceProviderIsService, whichActivatorUtilities(Hangfire, MVC, etc.) calls at runtime, so this shows up under production load.Fix
Take
lockObjectinCanGetInstance.Monitoris reentrant, so nested calls from withinCreateDelegateare unaffected.Tests
Issue614runsCanGetInstanceandGetInstanceconcurrently for many open generic enumerables with MS compatibility enabled. It fails consistently on master (corrupted lists from concurrentList.Add) and passes with the fix. Full suite passes (1562 tests).A separate, pre-existing issue where closed generic enumerables accumulate duplicate items in MS compatibility mode will be addressed in a follow-up PR.
🤖 Generated with Claude Code