Repository navigation
fix(identity): a Docker container id is not a server name - #410
Merged
Merged
Conversation
A container with no `hostname:` is named after the first twelve hex digits of its id, and `_host_name()` passed that straight through as `server_name`. The phone showed "Needs 8720566297e5" while away, and re-learned a new name on every recreate. Such a host now falls back to "Familiar"; a chosen `server_name` still wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Docker,
socket.gethostname()is the container id, so/contractand the Bonjour TXT record called the NAS8720566297e5, and the phone shows exactly that ("Needs 8720566297e5"). A hostname that is exactly twelve lowercase hex characters now falls back to "Familiar". Aserver_nameset in settings still wins.Phones pick up the new name on their next contract check (
ServerConfiguration.checkContractstores any name that differs).test_a_docker_container_id_is_not_a_name. It fails against the oldserver_identity.pyand passes with the fix.🤖 Generated with Claude Code