-
Notifications
You must be signed in to change notification settings - Fork 3
feat(fee): take the fee cap from the chain, not from three constants #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33d1584
fix(scenarios): size the ERC721 mint limit from a measurement
bdchatham 6c7e41d
feat(scenarios): add an AMM swap scenario
bdchatham 137675a
feat(health): serve healthz and readyz
bdchatham 7ce00e6
feat(gas): ask the chain what a call costs instead of hard-coding it
bdchatham 60d63a0
feat(fee): take the fee cap from the chain, not from three constants
bdchatham d51fb14
fix(gas): resolve limits at pricing time, and carry the value a call …
bdchatham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[suggestion]
NaN < 1and+Inf < 1are both false, so a config carrying either passes validation.GetGasFeeCapMultiplier(config/config.go) repeats the same< 1test and hands the value straight through, andscaleWeithen evaluatesint64(factor * scale)at generator/fee.go:50 — an out-of-range float-to-int conversion is implementation-defined in Go and yieldsMinInt64on amd64, producing a large negative fee cap that every subsequent transaction declares. A finite but huge multiplier (>~9.2e15) overflows the same conversion.Suggest rejecting non-finite values and bounding the upper end explicitly, e.g.
if math.IsNaN(s.GasFeeCapMultiplier) || s.GasFeeCapMultiplier < 1 || s.GasFeeCapMultiplier > someMax.