Repository navigation
Fix hostname-preferred cluster reconnects - #3346
Closed
meerasridharan-28 wants to merge 3 commits into
Closed
meerasridharan-28 wants to merge 3 commits into
meerasridharan-28 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CLUSTER SLOTSannounces a shard hostname whileCLUSTER NODESreports its companion IP, StackExchange.Redis could adopt or reconnect through the IP. In deployments that route one shared DNS endpoint using TLS SNI, that can prevent reconnection after topology changes.This change resolves known servers consistently across topology refreshes, refreshes aliases to the server selected by the current topology, and tracks the preferred dial endpoint for reconnects, TLS host/SNI, and tunnels. It preserves IP dialing when the topology prefers an IP. Regression coverage includes both pre-seeded endpoints and discovery from a single seed.
Validation:
dotnet test --project tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj -c Release -f net10.0 --filter-class StackExchange.Redis.Tests.ClusterTopologyUnitTests— passed (16 tests).Checklist