Fix element ownership tracking with may_dangle - #594
Open
charliermarsh wants to merge 1 commit into
Open
Conversation
alejandro-vaz
self-requested a review
September 8, 2026 16:30
Collaborator
|
this and #596 won't make it to v1.16.1, but we can make a second patch later |
Contributor
Author
|
Cool, thanks for the heads up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
may_dangleenabled, we currently allow references read by an element's destructor to expire before the vector is dropped, causing a use-after-free.Track ownership of
A::ItemwithPhantomDataso drop checking rejects this, including spilled vectors with zero inline capacity. Plain borrowed references without destructors retain the intendedmay_danglebehavior.