Skip to content

misc(url/redox): switch to the new scheme format - #1095

Open
Andy-Python-Programmer wants to merge 1 commit into
servo:mainfrom
Andy-Python-Programmer:main
Open

misc(url/redox): switch to the new scheme format#1095
Andy-Python-Programmer wants to merge 1 commit into
servo:mainfrom
Andy-Python-Programmer:main

Conversation

@Andy-Python-Programmer

@Andy-Python-Programmer Andy-Python-Programmer commented Jan 10, 2026

Copy link
Copy Markdown

No description provided.

@Andy-Python-Programmer
Andy-Python-Programmer marked this pull request as ready for review January 10, 2026 10:43
jackpot51 pushed a commit to redox-os/cargo that referenced this pull request Feb 2, 2026
@Andy-Python-Programmer
fix(Cargo.toml): use our fork of url
6fdb4c8 
To be removed when servo/rust-url#1095 has been
merged.

Signed-off-by: Anhad Singh <andypython@protonmail.com>
@mlinksva

mlinksva commented Nov 1, 2026 •
edited
Loading

Copy link
Copy Markdown

I can confirm that this PR works.

Building a hobby Rust project natively on Redox, stock Redox cargo 1.98.0-dev (8b241a6b6 2026-06-01) panics on the first vendored crate it loads:

panicked at src/tools/cargo/src/cargo/core/manifest.rs:375:9:
`file:/root/native/vendor/wasmparser-0.240.0/src/lib.rs` is not absolute

file_url_segments_to_pathbuf prepends file:, which today's Redox std treats as relative (Path::new("file:/root").is_absolute() == false).

With this PR applied to url 2.5.8, the same cargo commit (cross-built from Linux) no longer panics.

Added: It seems Redox carried this as a patch for its redox-2025-10-03 Rust port; its newer redox-2026-05-24 port, from which its packaged cargo 8b241a6b6 appears to be built, doesn't. Obviously it would be better to not have to carry the patch in any case.

@jackpot51

jackpot51 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@Andy-Python-Programmer this may have to be rebased

@Manishearth could you review this PR? Redox has been carrying a patch for the url crate for a long time.

@Andy-Python-Programmer
misc(url/redox): switch to the new scheme format
fce2dd4 
Signed-off-by: Anhad Singh <andypython@protonmail.com>
@Andy-Python-Programmer

Andy-Python-Programmer commented Nov 5, 2026

Copy link
Copy Markdown
Author

@jackpot51 done

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jackpot51 jackpot51 jackpot51 approved these changes
@eveeifyeve eveeifyeve eveeifyeve approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Andy-Python-Programmer @mlinksva @jackpot51 @eveeifyeve