Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting an opaque URL path containing
?or#currently puts those delimiters into the serialized URL without updating its query/fragment fields. Reparsing then changes the URL components.Encode those two delimiters in the path setter while retaining the existing opaque-path encoding rules and normal parsing of query/fragment delimiters. Tests cover existing query/fragment combinations, leading slashes, existing escapes, Unicode, and serialization round trips.
Fixes #1176.
Validation: the new delimiter regression fails on current main; the complete workspace test suite and 69 URL unit tests pass. Serde/exposed-internals and no-default-features/alloc suites, formatting, all-target builds and strict workspace Clippy also pass. Other platforms and the minimum Rust version were not executed.