Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_host(None)removes the serialized authority but leaves the previous host kind behind. With an empty path followed by a query or fragment it also panics in debug builds, and removing a host before a//path turns that path into a new authority when reparsed.Clear the host state, keep a root path when necessary, and preserve an empty first path segment with the existing
/.representation. Query/fragment offsets, credentials and port removal stay consistent with the serialization. Adding a host back also removes the synthetic/.prefix, keeping the actual//path intact.Fixes #1175.
Validation: four removal regressions fail on current main and pass with the fix; another host-prefix regression fails before the shared setter correction. The 72 URL unit tests and complete workspace default, serde/expose_internals and no-default-features/alloc suites pass. All-targets build, workspace strict Clippy and formatting checks pass. Tests cover domain/IPv4/IPv6 authorities, repeated removal and replacement, file URLs, existing rejection rules, empty paths and serialization round trips.