Skip to content

chore(workflows): perform lowest possible version testing - #8

Merged
shadowhand merged 3 commits into
mainfrom
chore/minimum-deps
Oct 8, 2026
Merged

shadowhand merged 3 commits into
mainfrom
chore/minimum-deps

Conversation

@shadowhand

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🏹 Robin

✅ Review done. I flagged 6 things worth a look.

Push fixes whenever you like, then comment /robin for another pass.

Robin v2.10.0 · antongulin/robin@main (d7b25da) · diff-only review (agent mode off)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Robin

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 4 Medium | 🔵 1 Low | 💡 1 Suggestions

Summary

The diff updates the CI workflow to use a matrix strategy for testing across multiple PHP versions and dependency configurations, and lowers version constraints for three php-standard-library packages. The matrix approach is a good improvement for test coverage, and the split install steps for lowest/default deps is well-designed. However, lowering the constraints from ^6.3 to ^6.0 for dict, json, and vec packages could allow incompatible older versions to be installed if the code relies on features from 6.3+. Additionally, testing against PHP 8.5 may fail if that version is not yet available in the setup-php action.


Robin — the Robin Hood of code review. Free for every PR.

Comment thread composer.json
Comment thread composer.json
Comment thread composer.json
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml Outdated
@shadowhand
shadowhand force-pushed the chore/minimum-deps branch 2 times, most recently from daaa95c to 30251d3 Compare October 8, 2026 08:56
@shadowhand

Copy link
Copy Markdown
Owner Author

/robin

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🏹 Robin

✅ Review done. I flagged 6 things worth a look.

Push fixes whenever you like, then comment /robin for another pass.

Robin v2.10.0 · antongulin/robin@main (d7b25da) · diff-only review (agent mode off)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Robin

Heads up: this is a point-in-time review. Push fixes freely, then comment /robin whenever you want another pass.

⚠️ 2 Medium | 🔵 3 Low | 💡 1 Suggestions

Summary

The diff adds a CI matrix strategy for testing across PHP versions and dependency versions, and lowers version constraints for php-standard-library packages. The changes are generally well-structured, but there are a few concerns: a potentially invalid phpunit CLI flag, removal of an explicit memory limit that was previously set, and removal of COMPOSER_AUTH that could affect private dependency installation.


Robin — the Robin Hood of code review. Free for every PR.

Comment thread .github/workflows/test.yml
Comment thread composer.json
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
@shadowhand
shadowhand merged commit ad0360a into main Oct 8, 2026
5 checks passed
@shadowhand
shadowhand deleted the chore/minimum-deps branch October 8, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant