Repository navigation
chore(workflows): perform lowest possible version testing - #8
Conversation
🏹 Robin✅ Review done. I flagged 6 things worth a look. Push fixes whenever you like, then comment Robin v2.10.0 · antongulin/robin@main (d7b25da) · diff-only review (agent mode off) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The diff updates the CI workflow to use a matrix strategy for testing across multiple PHP versions and dependency configurations, and lowers version constraints for three php-standard-library packages. The matrix approach is a good improvement for test coverage, and the split install steps for lowest/default deps is well-designed. However, lowering the constraints from ^6.3 to ^6.0 for dict, json, and vec packages could allow incompatible older versions to be installed if the code relies on features from 6.3+. Additionally, testing against PHP 8.5 may fail if that version is not yet available in the setup-php action.
Robin — the Robin Hood of code review. Free for every PR.
daaa95c to
30251d3
Compare
8e891ec to
5f5e04c
Compare
|
/robin |
🏹 Robin✅ Review done. I flagged 6 things worth a look. Push fixes whenever you like, then comment Robin v2.10.0 · antongulin/robin@main (d7b25da) · diff-only review (agent mode off) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The diff adds a CI matrix strategy for testing across PHP versions and dependency versions, and lowers version constraints for php-standard-library packages. The changes are generally well-structured, but there are a few concerns: a potentially invalid phpunit CLI flag, removal of an explicit memory limit that was previously set, and removal of COMPOSER_AUTH that could affect private dependency installation.
Robin — the Robin Hood of code review. Free for every PR.
5f5e04c to
565cacb
Compare
No description provided.