Repository navigation
ci: drop PHP from release workflow - #491
Merged
Merged
Conversation
json.php was only used to set CLI_VERSION and INSTALLER_VERSION in release.sh, and neither variable is read. Installing PHP on macos-14 now compiles it from source via Homebrew (~20 min), so remove the step, the unused assignments, and json.php.
shannah
marked this pull request as ready for review
October 3, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #490.
shivammathur/setup-phpalso installs PHP through Homebrew on macOS. Homebrew treatsmacos-14as a Tier 3 platform, so it still compiles PHP from source, which takes 10+ minutes in the v6.1.9 run.PHP was only used for
json.phpinrelease.sh, to setCLI_VERSIONandINSTALLER_VERSION. Neither variable is ever read, so this PR removes:.github/workflows/maven.ymlrelease.shjson.phpThe runner stays on
macos-14.macos-latestbroke native bundling during the v5.0.4 release, so moving off macos-14 is a separate question.Testing
bash -n release.shand a YAML parse of the workflow both pass.json.phpremain in the repo.🤖 Generated with Claude Code
https://claude.ai/code/session_01DVAtpWFds4ChBfFfuZWesT
Generated by Claude Code