This repository was archived by the owner on Oct 23, 2026. It is now read-only.
Repository navigation
feat: list open roles from Gem's job board API - #423
Merged
Merged
Conversation
Replaces the embedded Gem job board on /jobs with a list fetched from Gem's public job board API. Each role links to its Gem page to apply.
eseidel
enabled auto-merge (squash)
October 13, 2026 22:57
Contributor
|
🐦 Preview of 13a2e25: https://shorebird-website--pr-423-katso9gk.web.app (expires in 7 days) |
AbhishekDoshi26
left a comment
Member
There was a problem hiding this comment.
Reviewed the diff and checked the live API.
Verified OK:
GET https://api.gem.com/job_board/v0/shorebird-dev/job_posts/returns a bare array whose items havetitle,absolute_urlandlocation.name, soJobPostmatches. CORS reflects the request origin (shorebird.dev,www,*.web.apppreviews,localhostall allowed), so previews and local dev work too.- Using DOM APIs and
textContent(notinnerHTML) keeps Gem data from injecting markup. - All the custom utilities (
page-container,pb-section-l,pb-text-*,title-l/s,body-s/m,border-border,hover:bg-surface-2) exist inglobal.css. - If the response isn't an array,
for…ofthrows and the.catchhandles it.
One thing to fix:
- Blank gap when there are no roles or the fetch fails.
#job-listhasmin-h-24 pb-text-xl, so it always reserves ~96px plus spacing. That's good for avoiding layout shift while loading. But when Gem returns[], responds non-OK, or the request fails, the list stays an empty box between the intro and the "See all open positions" button. I'll push a fix that hides the list when nothing renders, so the page collapses to the intro and the fallback button.
AbhishekDoshi26
approved these changes
Oct 14, 2026
AbhishekDoshi26
left a comment
Member
There was a problem hiding this comment.
Re-reviewed at 13a2e25 with a fresh pass. The API shape matches JobPost; non-OK, network/CORS and non-array responses all end with the list hidden and the fallback link visible; Tailwind's [hidden] preflight (display:none !important) beats flex; there's no innerHTML; and all utilities exist. CI is green. LGTM.
Non-blocking follow-ups if wanted: role titles inherit the base a color (--text-2) rather than --text-1, and the list could use aria-live="polite" since roles arrive after load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the embedded Gem job board iframe on
/jobswith our own list, fetched in the browser from Gem's public job board API (api.gem.com/job_board/v0/shorebird-dev/job_posts/).npm run buildpasses. Checked locally in a browser: the list renders on desktop and mobile.