This repository was archived by the owner on Oct 23, 2026. It is now read-only.
Repository navigation
fix: restore vertical padding between page sections - #428
Merged
Merged
Conversation
The Webflow design put a section_m spacer (6rem, 2.5rem on mobile) at the top and bottom of every section, but Webflow never shipped a CSS rule for it, so sections sat 20px apart. Section now defaults to that padding; heroes keep their own spacing. Spacers and wrapper padding that compensated for the gap are removed so nothing doubles up.
Contributor
|
🐦 Preview of 8ebf7a8: https://shorebird-website--pr-428-kdnubxxi.web.app (expires in 7 days) |
AbhishekDoshi26
approved these changes
Oct 21, 2026
AbhishekDoshi26
left a comment
Member
There was a problem hiding this comment.
Reviewed. Built the branch and checked every Section and CtaBand usage. No blocking issues.
- Every hero uses
as="header"and keepspy-2.5. Demo'sspacing="l"matches the removed spacers to within about 10px. No caller passes aclassthat fights the new padding. CtaBandrenders the same markup as before (data-theme,data-section, the aria-hidden gradient, thepage-container). Only its vertical padding changes.- The FAQ, plan comparison, markdown and success-stories spacer removals are each replaced by the section padding. None of them doubles up.
- About's
-my-6/md:-my-16team grid is clipped by its ownoverflow-hiddenparent, so it isn't affected. - Non-blocking: some heroes still keep a trailing spacer (
pricing-details.astro:19-21,about.astro:88,product/shorebird-ci.astro:34), so the gap between the hero and the first section now differs across pages. On pricing it's about 146px. Worth a follow-up pass if you want the gap consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sections across the site sat 20px apart, so content from one section ran into the next (e.g. the platform section's column divider runs straight into the "Benefits" label on the home page).
This wasn't lost in the port. The Webflow design put a
g_spacer is--section_m(6rem, 2.5rem on mobile) at the top and bottom of nearly every section, but Webflow's CSS never had a rule for that class, so it rendered 0px on the old site too. The port reproduced that faithfully.Changes
Sectionnow defaults tospacing="m"(the--spacer-section-mtoken Webflow defined but never applied). Heroes (as="header") default tononesince they lay out their own spacing under the navbar.CtaBandused a hand-built copy ofSection's markup; it now usesSectionso it follows the same rule.spacing="l"), the FAQ wrapper's vertical padding, and the trailing hero spacers in the markdown layout and success stories index.section-spadding at the top to match its bottom; its logo sat against the top border.Result
Desktop: 96px above and below each content section (192px between neighbors). Mobile: 40px (80px between neighbors). To tighten it site-wide, change the default in
section.astrotos(128px / 64px).Checked in the dev server at 1440px on home, Code Push, pricing, about, and contact (screenshots), plus padding measurements on the blog index, a blog post, success stories, Shorebird CI, Jobs, and the home page at 390px.
cspell,build, andcheck:linkspass locally.format:checkpasses but does not parse.astrofiles.@AbhishekDoshi26 can you take a look?