Skip to content
This repository was archived by the owner on Oct 23, 2026. It is now read-only.

fix: restore vertical padding between page sections - #428

Merged
AbhishekDoshi26 merged 1 commit into
mainfrom
mc/padding-fix
Oct 21, 2026
Merged

AbhishekDoshi26 merged 1 commit into
mainfrom
mc/padding-fix

Conversation

@easymac

@easymac easymac commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Sections across the site sat 20px apart, so content from one section ran into the next (e.g. the platform section's column divider runs straight into the "Benefits" label on the home page).

This wasn't lost in the port. The Webflow design put a g_spacer is--section_m (6rem, 2.5rem on mobile) at the top and bottom of nearly every section, but Webflow's CSS never had a rule for that class, so it rendered 0px on the old site too. The port reproduced that faithfully.

Changes

  • Section now defaults to spacing="m" (the --spacer-section-m token Webflow defined but never applied). Heroes (as="header") default to none since they lay out their own spacing under the navbar.
  • CtaBand used a hand-built copy of Section's markup; it now uses Section so it follows the same rule.
  • Removed spacing that compensated for the missing padding and would now double up: the spacer divs in the product demo and pricing comparison (demo uses spacing="l"), the FAQ wrapper's vertical padding, and the trailing hero spacers in the markdown layout and success stories index.
  • Footer gets section-s padding at the top to match its bottom; its logo sat against the top border.

Result

Desktop: 96px above and below each content section (192px between neighbors). Mobile: 40px (80px between neighbors). To tighten it site-wide, change the default in section.astro to s (128px / 64px).

Checked in the dev server at 1440px on home, Code Push, pricing, about, and contact (screenshots), plus padding measurements on the blog index, a blog post, success stories, Shorebird CI, Jobs, and the home page at 390px. cspell, build, and check:links pass locally. format:check passes but does not parse .astro files.

@AbhishekDoshi26 can you take a look?

The Webflow design put a section_m spacer (6rem, 2.5rem on mobile) at the top and bottom of every section, but Webflow never shipped a CSS rule for it, so sections sat 20px apart. Section now defaults to that padding; heroes keep their own spacing. Spacers and wrapper padding that compensated for the gap are removed so nothing doubles up.
@github-actions

Copy link
Copy Markdown
Contributor

🐦 Preview of 8ebf7a8: https://shorebird-website--pr-428-kdnubxxi.web.app (expires in 7 days)

@AbhishekDoshi26 AbhishekDoshi26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Built the branch and checked every Section and CtaBand usage. No blocking issues.

  • Every hero uses as="header" and keeps py-2.5. Demo's spacing="l" matches the removed spacers to within about 10px. No caller passes a class that fights the new padding.
  • CtaBand renders the same markup as before (data-theme, data-section, the aria-hidden gradient, the page-container). Only its vertical padding changes.
  • The FAQ, plan comparison, markdown and success-stories spacer removals are each replaced by the section padding. None of them doubles up.
  • About's -my-6/md:-my-16 team grid is clipped by its own overflow-hidden parent, so it isn't affected.
  • Non-blocking: some heroes still keep a trailing spacer (pricing-details.astro:19-21, about.astro:88, product/shorebird-ci.astro:34), so the gap between the hero and the first section now differs across pages. On pricing it's about 146px. Worth a follow-up pass if you want the gap consistent.

@AbhishekDoshi26
AbhishekDoshi26 merged commit c19cf59 into main Oct 21, 2026
3 checks passed
@AbhishekDoshi26
AbhishekDoshi26 deleted the mc/padding-fix branch October 21, 2026 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants