Repository navigation
Conversation
loucass
force-pushed
the
fix/android-backup-transfer-storageid
branch
from
August 30, 2026 18:38
9372adb to
48eca2e
Compare
loucass
marked this pull request as draft
September 1, 2026 13:59
loucass
marked this pull request as ready for review
September 1, 2026 14:26
loucass
force-pushed
the
fix/android-backup-transfer-storageid
branch
from
September 1, 2026 15:07
c4252cc to
425c8dd
Compare
Author
|
Small update on this one. I dug into the actual crash log and the failure is an UPDATE on the self account row, so I centered the fix there: Also in this push:
Added tests for all three in RecipientTableTest — green here: Happy to adjust anything to match how you'd like it done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14954
Enabling backups during device transfer could hit UNIQUE constraint on recipient.storage_service_id (2067) and loop. Group import generated a random key without retry, so collision crashed the flow. Retry with new key up to 5 times and skip on persistent collision.