Repository navigation
Conversation
Author
|
Hey. Did maintainers take a vacation? When do they return? There was much more git activity a month ago. |
Contributor
|
Thanks for the PR, I'll let the design team know about the desire. In the end it's their call. I don't expect we'll take this change though, just to set your expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Different implementation of my PR #14933.
Some emoji images are fully black, which makes them invisible in chats and chat reactions when dark display theme is used. This PR adds a while background for these emojis, so they are visible with both light and dark display themes.
Before:

After:
