Skip to content

Draw white background for dark emojis when dark theme is used - #15026

Open
pelya wants to merge 1 commit into
signalapp:mainfrom
pelya:white-background-3
Open

pelya wants to merge 1 commit into
signalapp:mainfrom
pelya:white-background-3

Conversation

@pelya

@pelya pelya commented Sep 23, 2026

Copy link
Copy Markdown

First time contributor checklist

Contributor checklist

  • Bison GT2 5G, Android 12
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Different implementation of my PR #14933.
Some emoji images are fully black, which makes them invisible in chats and chat reactions when dark display theme is used. This PR adds a while background for these emojis, so they are visible with both light and dark display themes.

Before:
before-dark

After:
after-dark

@pelya

pelya commented Oct 7, 2026

Copy link
Copy Markdown
Author

Hey. Did maintainers take a vacation? When do they return? There was much more git activity a month ago.

@cody-signal

Copy link
Copy Markdown
Contributor

Thanks for the PR, I'll let the design team know about the desire. In the end it's their call. I don't expect we'll take this change though, just to set your expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants