Repository navigation
Conversation
Contributor
|
Hi there, this PR edits files that are no longer in use. Registration was rewritten a couple months ago, and this code hasn't been used since then. I should probably go clean it up now that the new version has stabilized. I don't think the new version has this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxNot run: no test command resolved in this workspace, so nothing was executed to pass.
Description
Add a distinct FAILURE_PASSPHRASE_VALIDATION result to RestoreRepository.BackupImportResult and return it only at the existing false result from FullBackupImporter.validatePassphrase; keep IOException mapped to FAILURE_UNKNOWN and retain the logged exception and finally cleanup. Update RestoreLocalBackupFragment.handleBackupImportError to handle the new result using the existing passphrase message and to display the existing RestoreLocalBackupActivity__backup_restore_failed string for FAILURE_UNKNOWN, with an accurate accompanying log message. Leave downgrade and foreign-key handling intact; the existing RestoreLocalBackupViewModel passes through the enum and requires no modification, and all enum references were inspected for exhaustive consumers.
Users restoring local backups receive “Incorrect backup passphrase” even with a verified key, sometimes after thousands of messages have already been read. The full thread includes confirmed incomplete/corrupted file transfers and Signal contributors explaining that unrelated restore exceptions are probably being mislabeled. The current legacy restore repository returns FAILURE_UNKNOWN both when passphrase validation returns false and when an IOException occurs; its fragment labels every such result as an incorrect passphrase. This plan fixes that concrete error-reporting defect, without promising recovery of damaged data or resolution of every historical restore failure collected in this thread.
Fixes #12743