Repository navigation
Apply screenshot security to the registration flow - #15037
Open
Andrea-Bruno wants to merge 2 commits into
Open
Andrea-Bruno wants to merge 2 commits into
Andrea-Bruno wants to merge 2 commits into
Conversation
Corrected the callback in NotificationsSettingsFragment to use setMessageNotificationVibration instead of setMessageNotificationsEnabled when toggling vibration setting. This ensures that disabling vibration doesn't turn off notifications entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal has a Screen security setting that blocks screenshots and screen recording on sensitive screens. The registration flow was not following that setting. During registration the app shows the phone number and the one-time verification code, so these are exactly the kind of screens the setting is meant to protect. When a user had Screen security turned on, the registration and code entry screens were still visible in a screen recording.
The fix makes the registration activity apply the same screenshot security that the rest of the app already uses. When the user has Screen security enabled, the registration window now sets the secure flag, so the phone number and the verification code are no longer captured by screen recording. When the setting is off, nothing changes.
This needed a change in the registration module because the registration flow runs in its own activity that does not extend the base activity where the setting is normally applied. The secure-window helper already lives in the shared core ui module, so the registration activity now calls it on create.
Closes #14450