Repository navigation
Conversation
The slider's semanticContentAttribute was hardcoded to .forceLeftToRight, which broke layout when the app runs under a right-to-left language. Now set based on CurrentAppContext().isRTL so the slider renders correctly regardless of layout direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Administrative:
Commits and testing:
Description
Fixes the video timeline slider not appearing when the app runs under a right-to-left language.
The slider's
semanticContentAttributewas hardcoded to.forceLeftToRight, which broke layout when the app runs under a right-to-left language. Now set based onCurrentAppContext().isRTLso the slider renders correctly regardless of layout direction.Tested by switching the App language to Arabic (RTL) and confirming the slider is now visible and scrubs correctly in the expected direction. Also verified no regression in English (LTR) — slider still renders and behaves as before.