Repository navigation
Conversation
In chats with a wallpaper, received bubbles are filled by a blurred wallpaper image that is only as tall as the screen. A bubble taller than that (a long message, or a larger text size) had no fill past the image, so text overflowed its background in the long-press preview. Fill the uncovered area with the wallpaper's average color, computed once per blurred image. Fixes signalapp#6356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Administrative:
Commits and testing:
Description
In chats with a wallpaper, received bubbles are filled by a blurred wallpaper image that is only as tall as the screen. A bubble taller than that (a long message, or a larger text size) had no fill past the image, so text overflowed its background in the long-press preview. I am able to reproduce this issue reliably on an iPhone 16 Pro running iOS 27.0.
Now uncovered area is filled with the wallpaper's average color, computed once per blurred image. This is a personal call for this change. Would love to get the team's take on this as this introduces a slight visual change when this edge case is hit.
Units test are added to prevent future regressions. I have tested the fix in a simulator by manually sending a longer-than-screen-height text and changing font size to large. The full Signal scheme passed with 1,663 tests passed, 0 failed and 12 skipped, out of the total 1,675 tests.
Fixes #6356