Repository navigation
Conversation
notwafel
marked this pull request as draft
October 10, 2026 17:36
Author
|
I have a new version of the settings and animations for adding/removing reactions on my PC, e.g. when someone reacts/unreacts to my message. I’ve submitted a pull request to draw because I need to test it thoroughly. |
notwafel
force-pushed
the
feature/double-tap-to-react
branch
2 times, most recently
from
October 10, 2026 22:54
da2229b to
6a3bd97
Compare
**Changes:** 1. Chats settings: double-tap for others' messages (React / Reply / Off, default React) and own messages (Edit / Reply / Off, default Edit) 2. Double-tap resolves via CVItemViewModelImpl.doubleTapAction (react / reply / edit) 3. Quick react uses the first emoji from the user's reaction bar 4. Optional toggles (default on): double-tap React on stickers and on photos/videos 5. When a double-tap action applies, single-tap on media/stickers is deferred so a fast double-tap reacts instead of opening the viewer or sticker pack details 6. Local reaction adds (picker / context menu / double-tap) go through one shared entrance path; removes skip the animation Tested: * iPhone 18 Pro Simulator (iOS 27.0) * iPhone 17 Simulator (iOS 27.0) * iPhone 13 mini Simulator (iOS 27.0)
notwafel
force-pushed
the
feature/double-tap-to-react
branch
from
October 10, 2026 23:02
6a3bd97 to
ec6945d
Compare
**Changes:** 1. Reaction add/remove reloads the cell with old→new frame animation so height expands or collapses 2. Local add: pill stays hidden until its size is stable, then shows and animates the emoji in 3. Remote add: short scale/fade entrance 4. Scroll continuity during reaction layout uses targetContentOffset so nearby messages don't jump 5. Suppresses reload crossfade on reaction reloads so ManualLayout does not ghost text
notwafel
force-pushed
the
feature/double-tap-to-react
branch
from
October 10, 2026 23:04
ec6945d to
cad5201
Compare
notwafel
marked this pull request as ready for review
October 10, 2026 23:09
Author
|
;d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
CVItemViewModelImpl.doubleTapActionand wired double-tap to react / reply / editReactionManager.preferredQuickReactionEmoji)First time contributor checklist
Contributor checklist
Description
Configurable double-tap shortcuts in Chats settings, optional quick-react on stickers/photos, deferred single-tap so fast double-tap can react on media/stickers, and a shared entrance animation for every local reaction add.