First I would like to thank you for your code and it has been used in my project, showing very impressive performance in computing efficiency and convenience. However, when recently I want to try to limit the spatial range of the Polyhedrons, I found the globalbox function offered by your code may has a BUG:https://github.com/sikang/DecompUtil/blame/b0836c7228d19f0fa97282c584b55adf642279da/include/decomp_util/ellipsoid_decomp.h#:~:text=Vs.add(Hyperplane3D(Vec3f(0%2C%20global_bbox_max_(1)%2C%200)%2C%20Vec3f(0%2C%20-1%2C%200)))%3B
I think this line should be Vs.add(Plane3D(Vec3f(0, global_bbox_min_(1), 0), Vec3f(0, -1, 0)));. Right? Or it will generate too many polyhedra than expected.
First I would like to thank you for your code and it has been used in my project, showing very impressive performance in computing efficiency and convenience. However, when recently I want to try to limit the spatial range of the Polyhedrons, I found the globalbox function offered by your code may has a BUG:https://github.com/sikang/DecompUtil/blame/b0836c7228d19f0fa97282c584b55adf642279da/include/decomp_util/ellipsoid_decomp.h#:~:text=Vs.add(Hyperplane3D(Vec3f(0%2C%20global_bbox_max_(1)%2C%200)%2C%20Vec3f(0%2C%20-1%2C%200)))%3B
I think this line should be
Vs.add(Plane3D(Vec3f(0, global_bbox_min_(1), 0), Vec3f(0, -1, 0)));. Right? Or it will generate too many polyhedra than expected.