LT-22641: Fix crash restoring a project from another computer - #1103
LT-22641: Fix crash restoring a project from another computer#1103papeh wants to merge 2 commits into
Conversation
Comment hygiene (advisory)1 comment-style violation(s) in the lines this branch adds since
Fix them per |
d72540d to
cc63a40
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
==========================================
- Coverage 38.34% 38.34% -0.01%
==========================================
Files 1507 1507
Lines 350586 350582 -4
Branches 40294 40294
==========================================
- Hits 134448 134434 -14
- Misses 186911 186921 +10
Partials 29227 29227
🚀 New features to boost your workflow:
|
* When getting the current dictionary configuration from the property table, ensure that the file exists. If the settings were restored from another computer, paths might not match, leading to a crash. * Default to dictionary configuration to prevent loading others unnecessarily.
8997eb2 to
9b09c10
Compare
Co-authored-by: Copilot <Copilot@users.noreply.github.com>
9b09c10 to
3d53e58
Compare
|
Looks like we could include a comment on this saying something like: Also we may be able to add a test for a reversal Word export asserting the homograph/sense-number settings survive. |
thejambi
left a comment
There was a problem hiding this comment.
See the comment I left, it may be good to address instead of leaving a question in the comments.
@thejambi reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on papeh).
When getting the current dictionary configuration from the property table, ensure that the file exists. If the settings were restored from another computer, paths might not match, leading to a crash.
CI-ready checklist
.github/commit-guidelines.md.build.ps1,test.ps1, or MSBuild).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is