Repository navigation
Decouple transport from hostname; store it in hgrc [chorus] section - #408
Open
hahn-kev-bot wants to merge 1 commit into
Open
hahn-kev-bot wants to merge 1 commit into
hahn-kev-bot wants to merge 1 commit into
Conversation
- Add HgTransportKind enum (HgWeb / Resumable) replacing BandwidthEnum - Save transport as `transport = hgweb|resumable` in [chorus] section of .hg/hgrc - Lexbox now serves both transports from hg-public/hg-private; legacy resumable.languageforge.org URLs are migrated to the standard host on load - BandwidthItem.Value → .Transport; AliasName no longer includes bandwidth - GetRepositoryPathsInHgrc propagates saved transport to returned addresses
3 of 4 tasks
Test Results 9 files ± 0 371 suites +24 53m 23s ⏱️ - 7m 23s Results for commit c7383f5. ± Comparison against base commit 0765ad6. This pull request removes 2 and adds 22 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes how transport is selected to use a parameter saved in hgrc, instead of determining based on the host name. This will let #406 define a 3rd option so we can release experiments without having a fallback.
AI summary
Summary
HgTransportKindenum (HgWeb/Resumable) replaces the implicit "does the URL contain 'resumable'?" heuristic for picking between hgweb and HgResume transports..hg/hgrcunder a new[chorus]section (transport = hgweb/transport = resumable), independent of the repository URL.ServerSettingsModel:BandwidthItemnow wrapsHgTransportKind;Transportproperty exposes the choice for both Lexbox and custom URLs.SaveSettingswrites the transport to hgrc in addition to setting the address.resumable.*hostname; that coupling is removed. Both transports are served fromhg-public/hg-private. Legacyresumable.languageforge.orgURLs are rewritten to the canonical host on load.InternetCloneSettingsModel.SetRepositoryAddresspasses the selected transport to both the address and the hgrc[chorus]section.HgTransportKind.Resumable.AliasNamenot including bandwidth, andHttpRepositoryPathtransport override.Testing
LibChorusTestspass on net8.0 and net462 (ServerSettingsModel, InternetCloneSettingsModel, RepositoryAddress, HgRepository test classes).Chorus.Testsserver-settings and clone tests pass on net462.This change is