Repository navigation
Conversation
Add /api/healthz/live, which skips the hg-tagged check, and point lexbox's startup and liveness probes at it. /api/healthz keeps the hg check for the deploy verification and the UI's version lookup. When hgweb's CGI path broke in prod, the hg check failed /api/healthz, k8s restarted lexbox every 5 minutes and the whole site was down instead of just the hg-backed features. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WFuZRPxsWu4zM4eHNZ
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
📦 Lexbox
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WFuZRPxsWu4zM4eHNZ
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
Add
/api/alive, which skips thehg-tagged check, and point lexbox's startup and liveness probes at it. When hgweb's CGI path broke in prod, the hg check failed/api/healthz, k8s restarted lexbox every 5 minutes and the whole site was down instead of just the hg-backed features. A liveness probe should only reflect faults a restart of that process can fix; hg's health isn't one./api/healthzis unchanged: the deploy workflow's version verification and the UI's version lookup read it, and the deploy check should keep requiring a reachable hg. The name matches the/api/alivethatWebServiceDefaultsalready gives FwHeadless. The OTel trace filter now covers both paths. No test added: there's noWebApplicationFactory-style test home for endpoints inbackend/Testing.Verified:
LexBoxApi.csprojbuilds;kubectl kustomizerenders production, develop and staging with both lexbox probes on the new path; the GHA integration tests start the lexbox pod with it. Related: #2879 (version mismatch is Degraded, so HTTP 200).🤖 Generated with Claude Code
https://claude.ai/code/session_01AM78WFuZRPxsWu4zM4eHNZ