Repository navigation
Conversation
The change preview showed the current headword in a button and the historical before/after anchor right below it, with nothing saying how the two relate. Object changes had no anchor at all. Each change now gets one header: the parent's current name as a muted crumb, the historical identity as a before/after inline diff that links to the entry, and a badge for what the change did (Added, Deleted, Removed, Moved, or "Now: X" when an entry's headword moved on since). The anchor moves out of the Entry/Sense/Example primitives into the header; the primitives keep it by default for standalone use. Object diffs get the primitives' changes-only mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WBzrZB97vduoZFtHSr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WBzrZB97vduoZFtHSr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WBzrZB97vduoZFtHSr
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
1 of 4 tasks
This was referenced Oct 31, 2026
Collaborator
Author
|
[Claude, autonomous] Combined into #2889 with #2883 and #2886. Generated by Claude Code |
myieye
added a commit
that referenced
this pull request
Nov 1, 2026
Activity diffs now narrow to what a change touched, each change gets one header, and a second tab compares the result of the change with the entity's current state. - Load ChangeContext.CurrentSnapshot with GetLatest, so a deleted entity comes back with DeletedAt set instead of being guessed from the affected entry. - Second tab reads Later changes, Deleted later (red label, Deleted badge, diffed against the last state before deletion) or No later changes (aria-disabled but still focusable). - Collapsed diffs also hide unchanged writing systems; "Show unchanged fields" shows the whole form. - Created or deleted entities show plain values with a green Added or red Deleted badge and an edge rule, not all-green or all-red text. - A muted "Now called: <headword>" line shows when a later change renamed the entry. - Fix the stray pink bar on homograph number changes and the n→m spacing. - Compare picture captions as plain text. Replaces #2883 and #2885. Homograph numbers on complex form links moved to #2890. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WGasYNwZjGRQswP6JQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
Stacked on #2883.
In #2883 an entry change showed the current headword in a button and the historical before→after anchor right below it, so the headword appeared twice with no stated relationship. Object changes had no anchor at all. Now every change gets one header:
[parent crumb, current, muted] › [historical identity as a before→after inline diff] [badge]. The identity text is the link to the entry.(Storybook
activity/change preview, demo data.)As built
Now: X(Headwords + HomographNumber) when the current headword or homograph number differs from the anchor's after-side;Now: Deletedwhen the entry was deleted sinceinfo.owningEntryHeadwordinfo.subject, sense number strippedSetOrderChange:*, from the change's$type)name; WS: name + muted wsId; SD:code nameDiffFieldRows mode="changes"withDiffCollapsed, filtered byvalueChangedActivityItemnow passes the change and itsIActivityChangeInfointo the preview. Ifinfo.subjectis null there's no crumb; "Not found" is gone.owningEntryHeadword, so a homograph subscript stays and only the trailing sense number (and the backend's gloss-less◌) is dropped.multiWindowServiceexists ("Open in new Window"). "Go to entry" is the link itself now.DiffEntryPrimitive/DiffSensePrimitive/DiffExamplePrimitivetakeanchor={false}andnoVisibleChangesNote={false}. Both default to on, so standalone use and the existing stories are unchanged. The anchor text lives inanchor-text.ts, shared by the primitives and the header. "No visible changes" moved toDiffNoVisibleChanges.svelte.role="group"witharia-label={changeName}, links are labelledGo to entry: {headword}/Go to word: {headword}, and every header target is at least 24×24 (checked in the browser).contain: inline-size, so a long unbreakable crumb can't widen its container.Deviations from the design
context.changeName, butActivityItemalready prints that name directly above the tabs, so it would show twice.Now: Deletedis shown when an edited entry was deleted later. The old button showed "(Deleted)". A bareDeletedbadge on an edit would read as "this change deleted it".HeadwordsfromaffectedEntries), falling back to the snapshot'scomponentHeadword. The link changes don't rename either entry, so a historical anchor would add nothing.Now: #,Go to entry: {0},Go to word: {0},More options, all with comments. Dropped:Complex form:,Component:,Not found.Test plan
svelte-check: 0 errors, 0 warningseslint: clean. The one warning, invitest.config.ts, was already there.vitest --project unit: 281 passed. New tests:change-header.test.ts(kind, reorder detection, badge, sense-number stripping, crumb splitting) andanchor-text.test.ts.i18n:extract, with translator comments addedactivity/change previewcovers all 20 cases. I checked it with Playwright and system Chrome at 1100px and 390px, light and dark: no horizontal scroll, no header target under 24px.editor/diff/entities"Changes only" adds the object changes-only rows.PNPM_CONFIG_VIRTUAL_STORE_TYPE=project).Open questions
change.change.$type, which the generatedIChangetype doesn't declare. Is it acceptable to rely on that serialized discriminator, or should the backend expose it, e.g. onIActivityChangeInfo?Now: Xwhen the gloss or sentence moved on since? Today only entries do, as specified.Generated by Claude Code