Repository navigation
[release] fix: warn when matter-server is older than the pin; /status reports the comparison (#75) - #370
Merged
Conversation
…erver with the pin (#75) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
… than the pin; expose in status (#75) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
…o to matter-server (#75) The launch agent plist points at the installed package's entry file and carries no version, so "writes the new version into its launch agent" was wrong. A plugin update rewrites the plist and reconnects to whatever is installed; only the menu item runs npm. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…pre-release counts as older; BACKUP_MENU, PINNED_VERSION Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
…/status matterServerVersionStatus Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
…hen in +build metadata is not a pre-release (#75) An oversized numeric component made int() raise past Python's digit limit, which would have surfaced as a /status failure. Build metadata may contain hyphens under semver, so the pre-release test now looks only before any '+'. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #75 got a fresh report on 2026-11-01 from a user on plugin v2026.33.0 still running matter-server 0.6.8. The pin moved to 1.2.2 in July (v2026.7.3), but upgrading the plugin never upgrades matter-server:
ensure_installed()only writes the plist and reconnects, and the npm install runs only from the Install/update the Matter controller menu item. The plugin logged the connected version at INFO and never compared it with the pin, so a six-months-stale server looked healthy and the #75 fix never reached existing installs.server_process.version_drift(sdk_version, install_spec)→(running, pinned, "older"|"current"|"newer"), orNoneonly when the comparison is impossible (missing/unparseable). Numeric compare; a pre-release of the pinned version counts as older (semver). Never raises. New constantsPINNED_VERSIONandBACKUP_MENU(both pinned toMenuItems.xml/DEFAULT_INSTALL_SPECby tests)._resync, after the fabric-label check, before the reconciletry), once per distinct version pair per plugin process:matter_client._handshakeclearsserver_infofirst, so a restart onto a new version never reports the previous server's version.matterServerPinnedVersion(always) andmatterServerVersionStatus(current|older|newer|unknown; last-known while disconnected; reported regardless of server location). Documented indocs/API.md. The mirroreddomio-code/docs/API.mdneeds the same two rows — separate PR there once this lands.INSTALL.md"Upgrading matter-server" says a plugin update does not upgrade matter-server and what the menu item actually does (installs the pin, restarts onto it);ARCHITECTURE.mdrow; CHANGELOG 2026.34.0.[release]in the title because the whole point is reaching existing installs; strip it if you would rather bank it.Warning as it appears:
Review
Four-agent review (code, tests, silent failures, comments) run before this revision; every finding is addressed in commits 72ce49d…HEAD. Headline change from review:
matterServerOutdated: falsecollapsed "current" and "could not tell", so it became the four-state string.Test plan
pytest -q: 4405 passed (32 new). Covers: helper parse/compare incl. pre-release and the real 0.6.2 golden string; managed warns once and re-warns for a different version; silent after upgrade to the pin; warns even whenget_nodesraises; order fabric-label → drift → reconcile pinned with a recorder; unmanaged → INFO without menu text; unreadable → one WARNING; helper raising →logger.exceptionand reconcile still runs; real_handshake → on_connectpath throughFakeWebSocket; status field over older/current/newer/unknown, disconnected last-known, unmanaged;server_infocleared on a non-dict reconnect frame; menu constants matchMenuItems.xml.currentpath and the status fields are observable there.Refs #75.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AMhQdWDSwUmj2y2rpi5fZH