feat: refactor value file structure

README.md

@@ -32,18 +32,22 @@ bmcPort: 443
 bmcScheme: https
 username: admin
 password: password
-model: "Standard PC (Q35 + ICH9, 2009)"
 firmwareVersion: "1.0.0"
-powerState: "On"
 biosVersion: "1.0.0"
-biosSettingNoRebootKey: "AssetTag"
-biosSettingNoRebootValue: "compat-test-06"
-biosSettingNoRebootBaselineValue: "compat-base"
-biosSettingRebootKey: "BootMode"
-biosSettingRebootValue: "Bios"
-biosSettingRebootBaselineValue: "Uefi"
-bmcSettingKey: "EmailAlert.1.Address"
-bmcSettingValue: "alerts@example.com"
+01-bmc-registration:
+  model: "Standard PC (Q35 + ICH9, 2009)"
+  powerState: "On"
+06-biossettings-noreboot:
+  key: "AssetTag"
+  value: "compat-test-06"
+  baselineValue: "compat-base"
+07-biossettings-reboot:
+  key: "BootMode"
+  value: "Bios"
+  baselineValue: "Uefi"
+08-bmcsettings:
+  key: "EmailAlert.1.Address"
+  value: "alerts@example.com"
 ```
 
 Adjust the credentials and expectations to your respective values and point the tests to it:

infra/kind/values-basic-go.yaml

@@ -3,6 +3,7 @@ bmcPort: 8000
 bmcScheme: http
 username: foo
 password: bar
-model: "15G Monolithic"
 firmwareVersion: "7.10.30.00"
-powerState: "On"
+01-bmc-registration:
+  model: "15G Monolithic"
+  powerState: "On"

infra/kind/values-contoso-go.yaml

@@ -3,6 +3,7 @@ bmcPort: 8000
 bmcScheme: http
 username: foo
 password: bar
-model: "Joo Janta 200"
 firmwareVersion: "1.45.455b66-rev4"
-powerState: "On"
+01-bmc-registration:
+  model: "Joo Janta 200"
+  powerState: "On"

tests/01-bmc-registration/chainsaw-test.yaml

@@ -31,6 +31,6 @@ spec:
                 name: (join('-', ['compatibility', $namespace]))
               status:
                 state: Enabled
-                model: ($values.model)
+                model: ($values."01-bmc-registration".model)
                 firmwareVersion: ($values.firmwareVersion)
-                powerState: ($values.powerState)
+                powerState: ($values."01-bmc-registration".powerState)

tests/06-biossettings-noreboot/biossettings-baseline.yaml

@@ -12,4 +12,4 @@ spec:
   settingsFlow:
     - name: noreboot
       priority: 1
-      settings: (from_items([[($values.biosSettingNoRebootKey), ($values.biosSettingNoRebootBaselineValue)]]))
+      settings: (from_items([[($values."06-biossettings-noreboot".key), ($values."06-biossettings-noreboot".baselineValue)]]))

tests/06-biossettings-noreboot/biossettings-noreboot.yaml

@@ -12,4 +12,4 @@ spec:
   settingsFlow:
     - name: noreboot
       priority: 1
-      settings: (from_items([[($values.biosSettingNoRebootKey), ($values.biosSettingNoRebootValue)]]))
+      settings: (from_items([[($values."06-biossettings-noreboot".key), ($values."06-biossettings-noreboot".value)]]))

tests/07-biossettings-reboot/biossettings-baseline.yaml

@@ -10,4 +10,4 @@ spec:
   settingsFlow:
     - name: reboot
       priority: 1
-      settings: (from_items([[($values.biosSettingRebootKey), ($values.biosSettingRebootBaselineValue)]]))
+      settings: (from_items([[($values."07-biossettings-reboot".key), ($values."07-biossettings-reboot".baselineValue)]]))

tests/07-biossettings-reboot/biossettings-reboot.yaml

@@ -10,4 +10,4 @@ spec:
   settingsFlow:
     - name: reboot
       priority: 1
-      settings: (from_items([[($values.biosSettingRebootKey), ($values.biosSettingRebootValue)]]))
+      settings: (from_items([[($values."07-biossettings-reboot".key), ($values."07-biossettings-reboot".value)]]))

tests/08-bmcsettings/bmcsettings.yaml

@@ -10,4 +10,4 @@ spec:
   settingsFlow:
     - name: bmc-setting
       priority: 1
-      settings: (from_items([[($values.bmcSettingKey), ($values.bmcSettingValue)]]))
+      settings: (from_items([[($values."08-bmcsettings".key), ($values."08-bmcsettings".value)]]))