fix: Propagate player disconnect and server-switch failures - #15
Open
frederickbaier wants to merge 1 commit into
Open
fix: Propagate player disconnect and server-switch failures#15frederickbaier wants to merge 1 commit into
frederickbaier wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnect and server-switch failures currently complete normally because
PlayerIntegrationdiscards controller replies and swallows exceptions. This hides the accurate disconnect failures introduced by controller PR 96 and prevents the Velocity and BungeeCord listeners’ existing error callbacks from running.Parse
PlayerDisconnectResponseandPlayerServerSwitchResponse, and complete the existing futures exceptionally onsuccess=false, missing replies, malformed replies, transport failures, or interruption. Failures identify the operation and player, preserve their underlying cause, and restore the interrupt flag when interrupted. Successful replies, including already-offline disconnects, still complete normally. Login behavior is unchanged; no retries are added.Validation:
./gradlew --configure-on-demand :api:check :platform:velocity:compileJava :platform:bungeecord:compileJava --console=plainpassed.Compatibility: this is a behavioral breaking change for callers relying on failures being silently ignored: these futures now complete exceptionally. There are no public signature changes, protobuf/schema changes, dependency upgrades, or database migrations. The current protobuf dependency supports both reply types. This can be deployed with the old controller, but backend disconnect failures that the old controller incorrectly reports as
success=trueremain undetectable until controller PR 96 is deployed.