Skip to content

[DH] adjust how many charges are refunded for mass accel and the hunt #11929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 2 commits into from
Oct 7, 2026
Merged

[DH] adjust how many charges are refunded for mass accel and the hunt #11929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bbde9f
mass acceleration refunds all reap charges
Aezeor Oct 7, 2026
f42b6ee
hunt refunds 1 soul immo charge with violent transformation on ptr still
Aezeor Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3162,7 +3162,7 @@ struct mass_acceleration_trigger_t : public BASE
switch ( BASE::dh()->specialization() )
{
case DEMON_HUNTER_DEVOURER:
BASE::dh()->cooldown.reap->reset( false );
BASE::dh()->cooldown.reap->reset( false, -1 );
break;
case DEMON_HUNTER_VENGEANCE:
BASE::dh()->cooldown.spirit_bomb->reset( true );
Expand Down Expand Up @@ -5546,11 +5546,9 @@ struct the_hunt_base_t

if ( s->chain_target == 0 && dh()->specialization() == DEMON_HUNTER_DEVOURER &&
dh()->talent.scarred.violent_transformation->ok() )
{
// only resets one charge of Soul Immo
if ( sim->dbc->wowv() < wowv_t( 12, 1, 5 ) )
dh()->cooldown.soul_immolation->reset( false, 1 );
}
// 10/06/2026 still refunds one charge on 12.1.5 even though developer notes say it should not
dh()->cooldown.soul_immolation->reset( false, 1 );
}
};

Expand Down
Loading