Skip to content

[Outlaw] Update Deft Maneuvers behavior for 12.1.5 #11944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EvanMichaels merged 3 commits into from
Oct 13, 2026
Merged

[Outlaw] Update Deft Maneuvers behavior for 12.1.5 #11944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57022c0
[Outlaw] Update Deft Maneuvers behavior for 12.1.5
soloxcx Oct 13, 2026
ec9b813
quick return
soloxcx Oct 13, 2026
bfac692
remove old deft bug (and rerun CI)
soloxcx Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions engine/class_modules/sc_rogue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2628,6 +2628,9 @@ class rogue_action_t : public Base
virtual double composite_poison_flat_modifier( const action_state_t* ) const
{ return 0.0; }

double cost_flat_modifier() const override
{ return ab::cost_flat_modifier(); }

double cost_pct_multiplier() const override
{
double c = ab::cost_pct_multiplier();
Expand Down Expand Up @@ -3926,17 +3929,6 @@ struct blade_flurry_t : public rogue_attack_t
return m;
}

void impact( action_state_t* state ) override
{
rogue_attack_t::impact( state );

// 2026-04-10 -- Whirl of Blades is triggered by Blade Flurry cast damage only with Deft talented
if ( p()->bugs && p()->talent.outlaw.deft_maneuvers->ok() )
{
p()->buffs.mid1_outlaw_4pc->trigger();
}
}

bool procs_main_gauche() const override
{ return true; }
};
Expand Down Expand Up @@ -3990,6 +3982,19 @@ struct blade_flurry_t : public rogue_attack_t
}
}

double cost_flat_modifier() const override
{
double c = rogue_attack_t::cost_flat_modifier();

if ( p()->talent.outlaw.deft_maneuvers->ok() )
{
c += std::min( instant_attack->target_list().size() * p()->talent.outlaw.deft_maneuvers->effectN( 3 ).base_value(),
p()->talent.outlaw.deft_maneuvers->effectN( 4 ).base_value() );
}

return c;
}

bool breaks_stealth() const override
{ return false; }
};
Expand Down
Loading