Repository navigation
Open uptime incidents only after a run of failed checks - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
failureThreshold: failed checks in a row that open an incident. Default 2, the admin API accepts 1 to 10, and 1 keeps the old behaviour. The first successful check still closes the incident.failurescount covers the whole run.checksanduptime_daily, so a single failure still lowers the uptime percentages.monitors.failure_threshold INTEGER NOT NULL DEFAULT 2; existing databases apply it on start.BEGIN IMMEDIATEand re-readuser_versioninside it, andbusy_timeoutis set first. Before, when the API and the uptime worker opened an existing database at once, one crashed withduplicate column name: failure_threshold.POST /api/admin/monitorstakesfailureThreshold;GET /api/monitorsreturns it.checks, so a restart or the separate worker keeps counting.Why
One failed check opened an incident, so a single timeout showed up as an outage of its own.
How it is tested
npm ci, lint, format check, typecheck, 129 tests and build pass on Node 22.22.2 and 24.22.0.docs/screenshots/uptime.pngstill shows single-check incidents; retaking it here would change its fonts.