Repository navigation
Keep the user's package.json when loading a script - #2579
Merged
Merged
Conversation
To load a .js script as CommonJS, Browsertime wrote an empty package.json next to the script and then deleted it. If the folder already had a package.json, it was overwritten and then deleted, so the user lost their file. Now the temporary file is only created when no package.json exists, and only that temporary file is removed. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To load a .js script as CommonJS, Browsertime wrote an empty package.json next to the script and then deleted it. If the folder already had a package.json, it was overwritten and then deleted, so the user lost their file.
Now the temporary file is only created when no package.json exists, and only that temporary file is removed.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com