Repository navigation
Escape the URL in the navigation script - #2582
Merged
Merged
Conversation
The URL under test was inserted into the navigation JavaScript as raw text inside double quotes. A URL containing a quote, a backslash or a line break broke navigation, and a crafted URL could run its own script in the page. The URL is now inserted as a JSON string literal. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL under test was inserted into the navigation JavaScript as raw text inside double quotes. A URL containing a quote, a backslash or a line break broke navigation, and a crafted URL could run its own script in the page. The URL is now inserted as a JSON string literal.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com