Repository navigation
Read bracket paths in metric lookups again - #4910
Merged
Merged
Conversation
Since lodash.get was replaced with an in-tree helper, paths written with bracket notation, like paintTiming['first-contentful-paint'], no longer matched anything. First Contentful Paint went missing from the Pages table, the summary box and the run page, and the run page also lost its render-phase breakdown, because that needs FCP. Configuration paths written in the lodash style broke the same way. The helper reads bracket notation again, the way lodash did. Plain dot paths are handled exactly as before. Fixes #4898 Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since lodash.get was replaced with an in-tree helper, paths written with bracket notation, like paintTiming['first-contentful-paint'], no longer matched anything. First Contentful Paint went missing from the Pages table, the summary box and the run page, and the run page also lost its render-phase breakdown, because that needs FCP. Configuration paths written in the lodash style broke the same way.
The helper reads bracket notation again, the way lodash did. Plain dot paths are handled exactly as before.
Fixes #4898
Assisted-by: Claude Opus 5.5 noreply@anthropic.com